[flashrom] [RFC] Coding style limits
audiohacked at gmail.com
Tue Dec 15 21:53:16 CET 2009
On 12/14/2009 8:31 PM, Carl-Daniel Hailfinger wrote:
> We currently have a 80-column limit in almost all files (except database
> like stuff in flashchips.c etc.).
> In the last few months, we have added more debug messages and more
> verbose and thus better understandable messages. Especially at a deep
> nesting level, using printf_debug can mean you have less than 20 chars
> per line left for messages. This actively reduces code readability.
> I would like to move the column limit from 80 to some other agreed-upon
> value, but I don't know which one.
> - 100
> - 120
> - 132
> What do YOU think?
The reason for 80-column limit is due to historical reasons, IMO, but we
could go with 4-space tabs and 100-column limit. I found with that
setting almost everything can be fit on a line if need be. Anything
bigger, I think there _is_ a better way to code a problem.
More information about the flashrom