[flashrom] [patch] add version information similar to 'uname -mrs'

Maciej Pijanka maciej.pijanka at gmail.com
Sun Dec 20 14:02:15 CET 2009


On Sun, 20 Dec 2009, Carl-Daniel Hailfinger wrote:

> On 20.12.2009 00:16, Idwer Vollering wrote:
> > Print 'uname -mrs' from the information collected at compile time.
> >
> > Signed-off-by: Idwer Vollering <vidwer at gmail.com>
> >   
> 
> Hmm. I'm sceptical about this one because it would only serve to catch
> miscompilations on broken systems. And in that case, the Makefile should
> refuse compilation.
> 

You have two different patches to choose from, one which embeds uname -msr into
compiled binary, one which reports system uname-like output fetched at runtime. 

Imo both combined give best possible info, both compile time (i would include
gcc version in this too) and runtime to catch situation where binary isn't
compiled on same machine as its running maybe compile time would be usefull to
easilly see if user runs newly compiled binary not old one (./flashrom vs
flashrom invocation). 

In case of detailed compile time info libftdi version might be usefull if its
compiled in.  I know that there was no problems with it so far but if make
something lets try at least to make that complete, sounds acceptable?

Maciej

-- 
Maciej Pijanka
reg. Linux user #133161




More information about the flashrom mailing list