[flashrom] [RFC] JEDEC refactor w/ conversion notes and file eliminations

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Fri Dec 25 23:47:35 CET 2009


Am Freitag, den 25.12.2009, 23:28 +0100 schrieb Carl-Daniel Hailfinger:

> > +	int byte_based_write;
> >   
> Can we please either postpone this and keep jedec_write_1 or at least
> rename the field to write_granularity (in bytes) or somesuch. The latter
> will require setting a boatload of chips to write_granularity=256, and
> the former will require more stuff inside jedec.c. Bah.

We definitely can not commit a patch that replaces write_jedec_1 by
write_jedec in flashchips.c without also changing page_size (after
verifying that it is not used as erase block size) or move to a
write_block_size (or write_granularity) setting that is correctly set
for all chips that use it. Stuff like:

> > diff --git a/flashchips.c b/flashchips.c
> > index 59f9139..af9039d 100644
> > --- a/flashchips.c
> > +++ b/flashchips.c
> > @@ -102,15 +102,15 @@ struct flashchip flashchips[] = {
> >  				},
> >  				.block_erase = erase_sector_jedec,
> >  			}, {
> >  				.eraseblocks = { {256 * 1024, 1} },
> >  				.block_erase = erase_chip_block_jedec,
> >  			},
> >  		},
> > -		.write		= write_jedec_1,
> > +		.write		= write_jedec,
> >  		.read		= read_memmapped,
> >  	},
> >  
> >  	{
> >  		.vendor		= "AMD",
> >  		.name		= "Am29F002(N)BT",
> >  		.bustype	= CHIP_BUSTYPE_PARALLEL,

will definitely break many very common chips.

Regards,
  Michael Karcher





More information about the flashrom mailing list