[flashrom] [PATCH] convert write_49fl00x to write_jedec_1

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Feb 27 16:29:23 CET 2010


On 27.02.2010 04:50, Sean Nelson wrote:
> Since we have a unlock interface for chips, I think we can convert the
> remaining references to *_49fl00x. Now the only remaining and used
> function in pm49fl00x.c is unlock_49fl00x. Added missing unlock to
> AMIC A49LF040A.

Looks good. Please note that if we ever delete write_49fl00x() we will
lose the lock sequence call. Maybe factor that one out to a separate
function lock_49fl00x.

> Signed-off-by: Sean Nelson <audiohacked at gmail.com>

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Regards,
Carl-Daniel

-- 
"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth





More information about the flashrom mailing list