[flashrom] [PATCH] flashrom dependencies

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Jun 7 13:09:32 CEST 2010


On 03.06.2010 15:38, Stefan Reinauer wrote:
> On 6/3/10 3:33 PM, Carl-Daniel Hailfinger wrote:
>   
>> On 30.03.2010 09:48, Stefan Reinauer wrote:
>>   
>>     
>>> On 3/30/10 5:12 AM, Carl-Daniel Hailfinger wrote:
>>>   
>>>     
>>>       
>>>> Unfortunately, this breaks make clean (and therefore make distclean) for
>>>> non-default configurations because OBJS will only contain the currently
>>>> selected modules. You can reproduce this easily with
>>>>
>>>> # make CONFIG_BITBANG_SPI=yes CONFIG_GFXNVIDIA=yes CONFIG_ATAHPT=yes
>>>> CONFIG_DEDIPROG=yes
>>>> # make clean
>>>>     
>>>>       
>>>>         
>>> Yes, it assumes, that you specify the same build flags on make clean,
>>> too. If that's not what you want, just change the $(OBJS)
>>> stuff to *.o *.d. I initially decided against this as some people are
>>> allergic when make clean does not only clean the stuff make created but
>>> operates with wild cards.
>>>   
>>>     
>>>       
>> Hm yes. The alternative would be to operate with two object lists: One
>> for files that are compiled in, and one for files that are not compiled in.
>>
>> I've followed your suggestion about replacing $(OBJS) with *.o *.d and
>> updated the patch to apply against svn trunk. Since the changes are
>> minimal, I kept your signoff. If you're unhappy with that, please tell
>> me and I'll remove it.
>>     
> No, go ahead... Thanks for doing this work
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Thanks, committed in r1034.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list