[flashrom] [PATCH] Annotate evil twins

David Borg borg.db at gmail.com
Sat Sep 4 02:35:04 CEST 2010

Updated to apply cleanly against current revision (1151). Changed the
bit used to indicate evil twins, as it is now used by FEATURE_WRSR_*



>On 22.07.2010 15:43, Daniel Lenski wrote:
>> On Thu, 2010-07-22 at 14:54 +0200, Carl-Daniel Hailfinger wrote:
>>> Evil twins are chips with identical IDs and different/incompatible
>>> characteristics (e.g. eraseblock layout, write strategy or size).
>>> Annotate them so flashrom can tell the user that it's not a matter of
>>> simply picking one of the chips in a list of multiple chips found.
>>> This patch only touches the AMIC A25L40PT and A25L40PU.
>>> I'm fairly sure there are more evil twins, but those two were touched
>>> recently.
>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2... at gmx.net>
>> I should point out that the A25L40PT and A25L40PU got erase-tested by
>> Rudolf Marek while we were trying to figure out if they were really evil
>> twins.  My patch added the erase-tested bit, but I think you took this
>> out.
>Yes, sorry for not mentioning this in the commit mail. Right now we only
>check if at least one erase function worked. There is no way (except
>editing the source code) to test all erase functions for a given chip.
>This will change once
>[PATCH] Move implicit erase out of chip drivers, clean up
>is committed and we have partial write.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1669.patch
Type: text/x-patch
Size: 2012 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100904/759a6480/attachment.patch>

More information about the flashrom mailing list