[flashrom] [PATCH] SPI bitbanging: request/release bus

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Sep 15 02:17:53 CEST 2010


On 15.09.2010 02:10, Carl-Daniel Hailfinger wrote:
> On 14.09.2010 14:31, Uwe Hermann wrote:
>   
>> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
>>
>>     
> SPI bitbanging on devices which speak SPI natively has a dual-use
> problem: We need to shut down normal SPI operations to do the bitbanging
> ourselves. Once we're done, it makes a lot of sense to reenable "normal"
> SPI operations again. Add request_bus/release_bus functions to struct
> bitbang_spi_master.
> Add a bitbang shutdown function (not used yet).
> Change MCP SPI and Intel NIC SPI to use the new request/release bus
> infrastructure.
>
> There are multiple possible strategies for bus request/release:
> - Request at the start of a SPI command, release immediately afterwards.
> - Request at the start of a SPI multicommand, release once all commands
> of the multicommand are done.
> - Request on programmer init, release on shutdown.
> Each strategy has its own advantages. For now, we will stay with the
> first strategy which worked fine so far.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>   

I reused your Ack.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Thanks, committed in r1171.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list