[flashrom] [PATCH] Reset before reading Chip ID
maciej.pijanka at gmail.com
Wed Sep 15 18:19:51 CEST 2010
On Wed, 15 Sep 2010, Carl-Daniel Hailfinger wrote:
> On 04.02.2010 07:13, Sean Nelson wrote:
> > I'd like Uwe, Stepan, or Carl-Daniel to test this and send an ack/nack.
> > On 1/31/10 8:07 AM, Anders Juel Jensen wrote:
> >> On Sunday 31 January 2010 06:33:12 Sean Nelson wrote:
> >>> Add a reset to probe_jedec before we read the Chip's IDs.
> >>> Signed-off-by: Sean Nelson <audiohacked at gmail.com>
> >> Acked-by: Anders Juel Jensen <andersjjensen at gmail.com>
> Sorry for the long delay. We absolutely want this patch, and I'm happy
> with it except for two minor issues:
> - Previous probes might have had too short delays for entering ID mode,
> so the chip may still be in the process of entering the ID mode. Due to
> that, an additional delay before the reset makes sense.
> - We needed FEATURE_RESET_MASK to deal cleanly with those feature bits.
> Maciej Pijanka tested the patch and it fixes probing for him with some
> old Atmel chips.
I checked current version of patch too, works here with nic3com and
AT29C512 in socket.
I don't fear computers, I fear lack of them -- Isaac Asimov
More information about the flashrom