[flashrom] [PATCH] Make all programmer/CLI options case-insensitive
uwe at hermann-uwe.de
Thu Aug 25 23:45:47 CEST 2011
On Fri, Jul 29, 2011 at 11:18:06PM +0200, Carl-Daniel Hailfinger wrote:
> Am 29.07.2011 14:55 schrieb Uwe Hermann:
> > Make all programmer/CLI options case-insensitive.
> > There's no need to make life for our user unnecessarily hard, and we already
> > have many case-insensitive options where strcasecmp() is used.
> > Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> I'm not sure this is a good idea. Our options/commands are
> case-sensitive (-V is totally different from -v), and making some
> parameters case-insensitive might lead people to assume that all
> parameters are case-insensitive.
I don't think that's an issue, it's probably pretty clear to most people
using CLI tools that options are almost always case-sensitive, but parameters
don't have to be. We can also additionally mention that in the manpage.
The behaviour should definately be consistent for the tool, though, even
if that means we convert everything to case-sensitive (though I'd much
It's very inconsistent for the tool to allow both
$ flashrom -p ft2232_spi:type=jtagkey,port=A
$ flashrom -p ft2232_spi:type=jTAgkEy,port=A
Whereas we explicitly force the user to use
$ flashrom -p internal:boardenable=force
and these will not work:
$ flashrom -p internal:boardenable=Force
$ flashrom -p internal:boardenable=FORCE
And also the user is forced to type/use:
$ flashrom -p dummy:emulate=SST25VF032B
$ flashrom -p dummy:emulate=sst25vf032b
will not work.
As Stefan said, force_I_want_a_brick may be the only exception (i.e., it
could really be case-sensitive) as we explicitly want to make it harder
for the user to type the string in this case.
http://hermann-uwe.de | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
More information about the flashrom