[flashrom] ck804 enable improvement
Stefan Reinauer
stefan.reinauer at coreboot.org
Fri Jan 21 07:28:32 CET 2011
* Jonathan A. Kollasch <jakllsch at kollasch.net> [110120 20:04]:
> Ensure all read and write locks are disabled on ck804.
>
> Signed-off-by: Jonathan Kollasch <jakllsch at kollasch.net>
> Index: chipset_enable.c
> ===================================================================
> --- chipset_enable.c (revision 1253)
> +++ chipset_enable.c (working copy)
> @@ -764,8 +764,50 @@
>
> static int enable_flash_ck804(struct pci_dev *dev, const char *name)
> {
> + uint32_t segctrl;
> + int segreg;
> uint8_t old, new;
>
> + for (segreg = 0x8c; segreg <= 0x97; segreg += 4) {
In steps of 4 this would be 8c, 90 and 94. So it would make sense to
write <= 0x94 or < 0x98 as that would be the next offset that's reached.
Otherwise:
Acked-by: Stefan Reinauer <stepan at coreboot.org>
But you might want to wait for some final words from Carl-Daniel.
Stefan
More information about the flashrom
mailing list