[flashrom] [PATCH 1/3] ichspi.c: refactor filling and reading the fdata/spid registers

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Wed Jul 13 15:33:50 CEST 2011

i have added a variable to hold (i % 4) in ich_fill_data:
unsigned int bite; /* offset of the current byte within a 32b word */

dunno if that makes it more or less readable? should i drop it again?
besides that i think there is not much room left for improvement.

and i got rid of the return values (hwseq needs a fixup to work with
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ichspi.c-refactor-filling-and-reading-the-fdata-spid.patch
Type: text/x-patch
Size: 5068 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110713/7cea55ea/attachment.patch>

More information about the flashrom mailing list