[flashrom] Additional voltages

Steven Zakulec spzakulec at gmail.com
Sat Jul 16 05:26:23 CEST 2011


On Mon, Jul 11, 2011 at 4:16 AM, Stefan Tauner <
stefan.tauner at student.tuwien.ac.at> wrote:

> On Sun, 10 Jul 2011 18:37:27 -0400
> Steven Zakulec <spzakulec at gmail.com> wrote:
>
> > Here's a new version rebased on r1368, with no extraneous changes.
>
> ok that's fixed, thank you. sorry for being so picky, but i noticed
> that the phrasing in your comments for identical features changes a lot.
>
> for the high voltage mode we have:
> /* 12 V fast program mode */
> /* 5.0V +-10% read, 12V fast program & erase- +-5% standard, +-10% option
> */
> (that dash should be a comma above btw?)
> /* Also offers a 12V fast program */
> /* Also has 12V fast program & erase */
>
> and for the ranges that are different in one speed grade we have:
> /* x speed is +-5%, all others +-10% */
> * x speed is 3.0-3.6V, others 2.7-3.6V */
> /* 3.0-3.6V (x), 2.7-3.6V for others */
>
> and for datasheets that define two ranges without giving any indication
> how to the chips can be distinguished we have:
> /* Datasheet says 2.5-3.6 V or 2.7-3.6 V */
> /* Datasheet says there's a 2.3-3.6V & 2.7-3.6V model */
> /* Datasheet says some are only 4.75-5.25 V */ (not sure if this is a speed
> grade case or belongs in this section)
>
> it would be good if those are unified so that it is easier to find them
> later, for example when we have a new feature flag or field that
> indicates a property directly in code instead of comments.
> the exact phrasing is not important as long as it is understandable for
> developers, but they should be equal (apart from the concrete values).
> this of course applies to past and future changes too.
> --
> Kind regards/Mit freundlichen Grüßen, Stefan Tauner
>
> _______________________________________________
> flashrom mailing list
> flashrom at flashrom.org
> http://www.flashrom.org/mailman/listinfo/flashrom
>
I believe I've adjusted the phrasings so there's one style for each comment
type.
The only issue I've come across is the Intel 28F002BC/BL/BV/BX-T.
>From my reading of the datasheets, the later two are compatible with each
other voltage-wise, but the BC and BL versions are definitely not- they have
non-overlapping ranges for reading.

Any thoughts?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110715/7fce3f97/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: voltage_patch-v7.patch
Type: text/x-diff
Size: 51672 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110715/7fce3f97/attachment.bin>


More information about the flashrom mailing list