[flashrom] [PATCH] chipset_enable.c: add a message in the case the chipset enable is untested

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Jul 21 22:55:07 CEST 2011


Am 21.07.2011 14:23 schrieb Stefan Tauner:
> old output:
> Found chipset "Intel QS57", enabling flash write... OK.
> This chipset supports the following protocols: FWH, SPI.
>
> new non-verbose output for tested chipsets:
> Found chipset "Intel QS57". Enabling flash write... OK.
> This chipset supports the following protocols: FWH, SPI.
>
> new non-verbose output for untested chipsets:
> Found chipset "Intel QS57".
> This chipset is marked as untested. If you are using an up-to-date version
> of flashrom please email a report to flashrom at flashrom.org including a
> verbose (-V) log. Thank you!
> Enabling flash write... OK.
> This chipset supports the following protocols: FWH, SPI.
>   

4 additional lines... sorry, but that's simply too much. We have users
of the DOS version of flashrom, and they have an 80x25 terminal, so
wasting 4 lines (16% of the screen) is not acceptable. 2 more lines are
already 8% of the screen.
The following text would be shorter (2 additional lines), but I'd be
happy to see a patch trimming it down even more to one additional line.

Found chipset "Intel QS57" (untested). Enabling flash write... OK.
If you are using an up-to-date version of flashrom please email a report
to flashrom at flashrom.org including a verbose (-V) log. Thank you!
This chipset supports the following protocols: FWH, SPI.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list