[flashrom] [PATCH] Add logfile support to flashrom

[Bernd Blaauw]

Op 13-6-2011 0:16, Carl-Daniel Hailfinger schreef:
> Yes, I'm interested. Please repost them to the list.

Done, see below.

Op 11-6-2011 16:21, Uwe Hermann schreef:
> There's a small issue with the patch, it double-prints some lines on 
> stdout
> now (in the logfile they appear only once if -o is used):
>
>    $ ./flashrom
>    flashrom v0.9.3-r1331 on Linux 2.6.38-2-amd64 (x86_64), built with 
> libpci 3.1.7, GCC 4.5.2, little endian
>    flashrom is free software, get the source code at 
> http://www.flashrom.org

On DOS platform, I see this "little endian" text truncated as
", l"
"ittle endian"
"flashrom is free".

must be the 80x25 default screen mode. Anyway to make this pretty 
instead of cutting words?

>
>    flashrom v0.9.3-r1331 on Linux 2.6.38-2-amd64 (x86_64), built with 
> libpci 3.1.7, GCC 4.5.2, little endian
>    Calibrating delay loop... OK.
>    ERROR: Could not get I/O privileges (Operation not permitted).
>    You need to be root.
>
> Also, not all whitespace seems to be the same as in the logfile, e.g. for
>
>    $ ./flashrom -L -o foo
>

Seems like Uwe's right about the empty spaces, experienced the same with 
Idwer's "latest" DOS binary.

Just curious: does FlashROM have any operations that don't require root 
on Linux?
Otherwise you'd simply give the "you need to be root" warning before 
doing calibration loop, saving a second of waiting time or so?

Last cosmetic gripe: "bad command or filename" printed 6 times in case 
FlashROM can't find the (hopefully optional?) DOS "DMIDECOD" program.

Is the logfile purely optional? A plain simple bootCD with DOS, FlashROM 
and BIOS file means a read-only filesystem.
As not all writes might be succesfull, is it an idea to read the BIOS 
backup in pogram memory (instead of storing on disk) and offer to 
restore it in case writing new file goes bad?
That would be nice on read-only platforms (or those without enough space 
to write file to)