[flashrom] [PATCH] Reenable forced read

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Feb 16 22:01:12 CET 2012


Am 16.02.2012 21:24 schrieb Stefan Tauner:
> On Thu, 16 Feb 2012 21:18:06 +0100
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>
>> Am 16.02.2012 19:15 schrieb Carl-Daniel Hailfinger:
>>> Forced read functionality was disabled when programmer registration was
>>> merged in r.
>>>
>>> We now support registering more than one controller at once for each bus
>>> type. This can happen e.g. if one SPI controller has an attached flash
>>> chip and one controller doesn't. In such a case we rely on the probe
>>> mechanism to find exactly one chip, and the probe mechanism will
>>> remember which controller/bus the flash chip is attached to. A forced
>>> read does not have the luxury of knowing which compatible controller to
>>> use, so this case is handled by always picking the first one. That may
>>> or may not be the correct one, but there is no way (yet) to specify
>>> which controller a flash chip is attached to.
>>>
>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> as discussed on IRC this one does not segfault when there are no
> registered programmers, hence
> Acked-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>

Thanks, committed in r1496.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list