[flashrom] [PATCH 2/5] Introduce and use enum test_state
Stefan Tauner
stefan.tauner at student.tuwien.ac.at
Mon Feb 20 19:31:23 CET 2012
On Mon, 20 Feb 2012 18:17:58 +0100
Idwer Vollering <vidwer at gmail.com> wrote:
> > -#define OK 0
> > -#define NT 1 /* Not tested */
> > +enum test_state {
> > + OK = 0,
> > + NT = 1, /* Not tested */
> > + BAD
>
> BAD = -1 ?
i would prefer to leave it undefined. one point of using enums is to be
implementation-agnostic. the other values are only forced to 0/1 to not
break previously existing stuff, that relies on the values.
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom
mailing list