[flashrom] [PATCH] flashrom.c: Reorder list of options to test

Paul Menzel paulepanter at users.sourceforge.net
Thu Jan 12 02:10:10 CET 2012


Date: Thu, 12 Jan 2012 01:59:42 +0100
Subject: [PATCH] flashrom.c: Reorder list of options to test

If a chip is unknown the user is asked to test and report the result to the mailing list. Having `-VE` listed as the last option can result in an unbootable system for users not knowing what the command does, since rebooting the system after that command is fatal since the flash chip is empty. [1]

Reorder the options as a quick fix to prevent that in the future as suggested by idwer on #flashrom.

[1] http://www.flashrom.org/pipermail/flashrom/2012-January/008551.html

Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 flashrom.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/flashrom.c b/flashrom.c
index f1a6165..ee68344 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -1600,7 +1600,7 @@ void check_chip_supported(const struct flashctx *flash)
 			    "include the flashrom\n"
 			  "output with the additional -V option for all "
 			    "operations you tested (-V, -Vr,\n"
-			  "-Vw, -VE), and mention which mainboard or "
+			  "-VE, -Vw), and mention which mainboard or "
 			    "programmer you tested.\n"
 			  "Please mention your board in the subject line. "
 			    "Thanks for your help!\n");
-- 
1.7.8.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20120112/267d9075/attachment.asc>


More information about the flashrom mailing list