[flashrom] [PATCH 05/10] Use uintptr_t for chipaddr instead of unsigned long.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Jul 14 01:34:40 CEST 2013


Am 14.07.2013 01:32 schrieb Stefan Tauner:
> On Sat, 13 Jul 2013 18:07:22 +0200
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>
>> This looks too good to be viable. I have a bad feeling about this in the
>> context of 64-bit resources on x86 (32bit), but drivers accessing
>> resources shouldn't be using chipaddr anyway.. That said, it should not
>> result in any breakage on 32bit platforms. We may see pretty explosions
>> once we start supporting the x32 pseudo-arch. But that will need an
>> audit of the codebase anyway.
> What kind of 64b resources are you thinking about here?

64-bit PCI memory BARs. Those can exist on x86_64 systems running x86
flashrom. But AFAICS that PCI code is not affected by this change.

Regards,
Carl-Daniel




More information about the flashrom mailing list