[flashrom] Building on Windows with mingw

[Márton Miklós]

>
> Hi,
>
> I have been reading about the printf format on MinGW for another
> project and I run into this message.
>
> Miklos are you still experiencing the problem?
>
> Here on Linux with mingw-w64 version 5.0.3 the constant is here in
> /usr/share/mingw-w64/include/stdio.h
>
>> I have used the latest available mingw-get-setup, because the 20110530
>> version (which mentioned in the wiki as known t obe working) segfaults
>> when I select the MSYS Basic System feature.
>>
>> I can build with WARNERROR=no, but some more permanent fix
>> recommentation would be warmly welcome!
>>
> I think a change like the following can help:
>
>
> diff --git a/flash.h b/flash.h
> index a80a9c2..4ae5808 100644
> --- a/flash.h
> +++ b/flash.h
> @@ -359,7 +359,7 @@ void start_logging(void);
>   int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap);
>   /* Let gcc and clang check for correct printf-style format strings. */
>   int print(enum flashrom_log_level level, const char *fmt, ...)
> -#ifdef __MINGW32__
> +#ifdef __MINGW_PRINTF_FORMAT
>   __attribute__((format(__MINGW_PRINTF_FORMAT, 2, 3)));
>   #else
>   __attribute__((format(printf, 2, 3)));
>
>
> In case the constant is not defined the compiler may still give warnings
> but at least the code will compile.
>
> If the change looks good I can forward it through the proper channels.
> BTW are patches sent via git-send-email accepted?
>
> Ciao,
>     Antonio
Hey Antonio,

Thank you very much for your email, it solves one part of the problem on 
Windows.
Now I got the following warnings:

dummyflasher.c: In function 'dummy_init':
dummyflasher.c:379:12: warning: unknown conversion type character 'j' in 
format [-Wformat=]
    msg_pdbg("Found persistent image %s, %jd B ",
             ^
flash.h:350:49: note: in definition of macro 'msg_pdbg'
  #define msg_pdbg(...) print(FLASHROM_MSG_DEBUG, __VA_ARGS__) /* 
programmer debug */
                                                  ^~~~~~~~~~~
dummyflasher.c:379:12: warning: too many arguments for format 
[-Wformat-extra-args]
    msg_pdbg("Found persistent image %s, %jd B ",
             ^

Best regards,
Miklos Marton