<div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 26, 2012 at 8:48 PM, Stefan Tauner <span dir="ltr"><<a href="mailto:stefan.tauner@student.tuwien.ac.at" target="_blank">stefan.tauner@student.tuwien.ac.at</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div>did you really test the 1.8V version too?<br></div>
</div></blockquote><div><br></div>
<div>Nope. We can set that to UNTESTED if you prefer, though I don't think there's much reason to suspect it will fail when the 3V version works.</div><div><br></div><div>On Thu, Jul 26, 2012 at 8:48 PM, Stefan Tauner <span dir="ltr"><<a href="mailto:stefan.tauner@student.tuwien.ac.at" target="_blank">stefan.tauner@student.tuwien.ac.at</a>></span> wrote:</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div></div></div>
<div><br>
> .probe = probe_spi_rdid,<br>
> .probe_timing = TIMING_ZERO,<br>
> @@ -5450,9 +5454,44 @@<br>
> .unlock = spi_disable_blockprotect,<br>
> .write = spi_chip_write_256,<br>
> .read = spi_chip_read,<br>
> + .voltage = {1700, 2000},<br>
> },<br>
><br>
> {<br>
> + .vendor = "Numonyx",<br>
> + /* ..3E = 3V, uniform 64KB/4KB blocks/sectors */<br>
> + .name = "N25Q064..3E",<br>
> + .bustype = BUS_SPI,<br>
> + .manufacture_id = ST_ID,<br>
> + .model_id = ST_N25Q064__3E,<br>
> + .total_size = 8192,<br>
> + .page_size = 256,<br>
> + /* supports SFDP */<br>
<br>
</div>Does it work as expected (testable by removing the chip definition)?<br></blockquote><div><br></div><div>Obviously not or I wouldn't have bothered to make a patch for it :-)</div><div><br></div><div>On Thu, Jul 26, 2012 at 8:48 PM, Stefan Tauner <span dir="ltr"><<a href="mailto:stefan.tauner@student.tuwien.ac.at" target="_blank">stefan.tauner@student.tuwien.ac.at</a>></span> wrote: </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">There are a number of other N25Q* chips available apparently. Do you<br>
plan to add them too (NB: <a href="http://patchwork.coreboot.org/patch/3652/" target="_blank">http://patchwork.coreboot.org/patch/3652/</a>)?<br>
Anyone else? Steven, our datasheet muncher maybe? :)<br></blockquote><div><br></div><div>Would if I had more time...</div><div><br></div><div>-- <br></div></div>David Hendricks (dhendrix)<br>Systems Software Engineer, Google Inc.<br>
</div>