<div dir="ltr">Hi Cédric,<div>Thanks for the patches. Indeed, 4BA is a feature that we've been looking at for a while. I'll look forward to reviewing these patches in detail.</div><div><br></div><div>There are a few cases that need to be considered:</div><div>- Chips which have a command to switch to 4BA mode</div><div>- Chips which have a parallel instruction set for use with 4BA.</div><div>- Chips that exclusively use 4BA commands.</div><div><br></div><div>I tried to cover the first two cases in my patch: <a href="https://chromium-review.googlesource.com/#/c/323359/">https://chromium-review.googlesource.com/#/c/323359/</a></div><div>The third case was brought to our attention by Tim Chick: <a href="http://patchwork.coreboot.org/patch/4437/">http://patchwork.coreboot.org/patch/4437/</a></div><div><br></div><div>Hopefully we can come up with a good solution for all cases.</div><div> </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jun 11, 2016 at 9:28 AM, Cédric Le Goater <span dir="ltr"><<a href="mailto:clg@kaod.org" target="_blank">clg@kaod.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
Here's an old patchset proposed a while ago by Boris Baykov to add<br>
4byte support to flashrom. I have been using it to flash N25Q256<br>
modules from a raspberry pi quite successfully. Could we restart a<br>
review cycle to see what needs fixing ?<br>
<br>
A port of the complete patchset on 0.9.9 is available here :<br>
<br>
<a href="https://github.com/legoater/flashrom" rel="noreferrer" target="_blank">https://github.com/legoater/flashrom</a><br>
<br>
Thanks,<br>
<br>
C.<br>
<br>
Boris Baykov (6):<br>
4BA: Basic support for 4-bytes addressing mode extensions<br>
4BA: Flashrom integration for the 4-bytes addressing extensions<br>
4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode<br>
4BA: Support for 4-bytes addressing via Extended Address Register<br>
4BA: Support for new direct-4BA instructions + W25Q256.V update<br>
4BA: Progress visualization for long read, writes and erases<br>
<br>
Makefile | 2 +-<br>
chipdrivers.h | 22 ++<br>
cli_output.c | 3 +-<br>
flash.h | 21 ++<br>
flashchips.c | 48 +++<br>
flashrom.c | 61 ++++<br>
serprog.c | 5 +-<br>
spi.c | 5 +-<br>
spi25.c | 37 ++-<br>
spi4ba.c | 920 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++<br>
spi4ba.h | 114 ++++++++<br>
11 files changed, 1231 insertions(+), 7 deletions(-)<br>
create mode 100644 spi4ba.c<br>
create mode 100644 spi4ba.h<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.1.4<br>
<br>
<br>
_______________________________________________<br>
flashrom mailing list<br>
<a href="mailto:flashrom@flashrom.org">flashrom@flashrom.org</a><br>
<a href="https://www.flashrom.org/mailman/listinfo/flashrom" rel="noreferrer" target="_blank">https://www.flashrom.org/mailman/listinfo/flashrom</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">David Hendricks (dhendrix)<br>Systems Software Engineer, Google Inc.</div>
</div>