<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:\65B0\7D30\660E\9AD4;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:\7D30\660E\9AD4;
panose-1:2 2 5 9 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@\65B0\7D30\660E\9AD4";
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"\@\7D30\660E\9AD4";
panose-1:2 2 5 9 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"\65B0\7D30\660E\9AD4","serif";}
pre
{mso-style-priority:99;
mso-style-link:"HTML \9810\8A2D\683C\5F0F \5B57\5143";
margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:\7D30\660E\9AD4;}
span.HTML
{mso-style-name:"HTML \9810\8A2D\683C\5F0F \5B57\5143";
mso-style-priority:99;
mso-style-link:"HTML \9810\8A2D\683C\5F0F";
font-family:\7D30\660E\9AD4;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-TW" link="blue" vlink="purple" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Dear Maintainers ,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> This patch is for the following description:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" style="text-indent:24.0pt"><span lang="EN-US">Transaction is failed and errors are shown when flashrom try to read region that locked by Intel ME. <o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:24.0pt"><span lang="EN-US">This patch simply disable code to check error (will read 0xff) then flashrom will continue to read the rest. And only ignore the error when read op. It will output a warning message to stderr
like: <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> Transaction (READ) error at address 0x001000-0x7fffff, ignored<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:24.0pt"><span lang="EN-US">To avoid a lot of similar error messages, it shows error at end of locked region.<o:p></o:p></span></p>
<p><span lang="EN-US" style="font-family:"Calibri","sans-serif"">Thanks!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black">Sign-off-by: Tommy Lo < tommy.lo@advantech.com.tw ><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Index: ichspi.c<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">===================================================================<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">--- ichspi.c (revision 1955)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+++ ichspi.c (working copy)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">@@ -178,6 +178,9 @@<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> static void *ich_spibar = NULL;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+/* keep last addr of read error */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+static uint32_t last_read_warn_addr = 0xFFFFFFFF;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">typedef struct _OPCODE {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> uint8_t opcode; //This commands spi opcode<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> uint8_t spi_type; //This commands spi type<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">@@ -946,14 +949,38 @@<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> /* FIXME make sure we do not needlessly cause transaction errors. */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> temp32 = REGREAD32(ICH9_REG_SSFS);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> if (temp32 & SSFS_FCERR) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- msg_perr("Transaction error!\n");<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- prettyprint_ich9_reg_ssfs(temp32);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- prettyprint_ich9_reg_ssfc(temp32);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- /* keep reserved bits */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- temp32 &= SSFS_RESERVED_MASK | SSFC_RESERVED_MASK;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- /* Clear the transaction error. */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- REGWRITE32(ICH9_REG_SSFS, temp32 | SSFS_FCERR);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- return 1;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (ichspi_lock && op.spi_type == SPI_OPCODE_TYPE_READ_WITH_ADDRESS) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ /* keep reserved bits */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ temp32 &= SSFS_RESERVED_MASK | SSFC_RESERVED_MASK;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ /* Clear the transaction error. */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ REGWRITE32(ICH9_REG_SSFS, temp32 | SSFS_FCERR);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (last_read_warn_addr != 0xFFFFFFFF) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (last_read_warn_addr == (offset - 1)) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ /* continuing */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ last_read_warn_addr = offset + datalength - 1;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ } else {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ msg_pdbg("-0x%06x, ignored\n", last_read_warn_addr);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ last_read_warn_addr = 0xFFFFFFFF;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ } else {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ msg_pdbg("Transaction (READ) error at address 0x%06x", offset);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ last_read_warn_addr = offset + datalength - 1;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ } else {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ prettyprint_ich9_reg_ssfs(temp32);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ prettyprint_ich9_reg_ssfc(temp32);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ /* keep reserved bits */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ temp32 &= SSFS_RESERVED_MASK | SSFC_RESERVED_MASK;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ /* Clear the transaction error. */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ REGWRITE32(ICH9_REG_SSFS, temp32 | SSFS_FCERR);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ msg_perr("Transaction error!\n");<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ return 1;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ } else {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (last_read_warn_addr != 0xFFFFFFFF) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ msg_pdbg("-0x%06x, ignored\n", last_read_warn_addr);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ last_read_warn_addr = 0xFFFFFFFF;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> if ((!write_cmd) && (datalength != 0))<o:p></o:p></span></p>
</div>
</body>
</html>