Changeset 1021 for trunk/physmap.c

Timestamp:

05/31/10 00:24:40 (2 years ago)

Author:

hailfinger

Message:

Remove unneeded #include statements completely.

unistd.h was only used to get a definition of NULL in all files. Add our
own NULL #define and remove unistd.h from flash.h
stdio.h has no place in flash.h, it should be included only in files
which really need it.
Add #include statements in individual .c files where needed.

Replace a few printf with msg_* to eliminate the need for stdio.h.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@…>
Acked-by: Uwe Hermann <uwe@…>

File:

• trunk/physmap.c (modified) (3 diffs)

trunk/physmap.c

@@ -21 +21 @@
  */
 
+#include <unistd.h>
+#include <stdio.h>
 #include <sys/types.h>
 #include <sys/stat.h>
@@ -311 +313 @@
 {
         char msrfilename[64];
-        memset(msrfilename, 0, 64);
-        sprintf(msrfilename, "/dev/cpu/%d/msr", cpu);
+        memset(msrfilename, 0, sizeof(msrfilename));
+        snprintf(msrfilename, sizeof(msrfilename), "/dev/cpu/%d/msr", cpu);
 
         if (fd_msr != -1) {
@@ -394 +396 @@
 {
         char msrfilename[64];
-        memset(msrfilename, 0, 64);
-        sprintf(msrfilename, "/dev/cpu%d", cpu);
+        memset(msrfilename, 0, sizeof(msrfilename));
+        snprintf(msrfilename, sizeof(msrfilename), "/dev/cpu%d", cpu);
 
         if (fd_msr != -1) {