Changeset 1418

Timestamp:

08/20/11 16:16:00 (9 months ago)

Author:

uwe

Message:

Makefile: Fix MinGW build, improve output with bogus CC.

As per IRC discussion, the "ARCH :=" line should be moved after any
lines which set CC, as it uses CC itself. This fixes the MinGW build.

Also, add a "2>/dev/null" in the "ARCH :=" as per suggestion from
Stefan Tauner to improve the output in the case CC is bogus:

Before:
$ make CC=foo
/bin/sh: foo: not found
Checking for a C compiler... not found.
make: * [compiler] Error 1

After:
$ make CC=foo
Checking for a C compiler... not found.
make: * [compiler] Error 1

Signed-off-by: Uwe Hermann <uwe@…>
Acked-by: Stefan Tauner <stefan.tauner@…>

File:

• trunk/Makefile (modified) (2 diffs)

trunk/Makefile

@@ -38 +38 @@
 endif
 
-# Determine the destination processor architecture
-override ARCH := $(strip $(shell LC_ALL=C $(CC) -E arch.h|grep -v '^\#'))
-
 # FIXME We have to differentiate between host and target OS architecture.
 OS_ARCH ?= $(shell uname)
@@ -202 +199 @@
 endif
 endif
+
+# Determine the destination processor architecture.
+# IMPORTANT: The following line must be placed before ARCH is ever used
+# (of course), but should come after any lines setting CC because the line
+# below uses CC itself. In some cases we set CC based on OS_ARCH, see above.
+override ARCH := $(strip $(shell LC_ALL=C $(CC) -E arch.h 2>/dev/null | grep -v '^\#'))
 
 ifeq ($(ARCH), "ppc")