[flashrom] [commit] r814 - trunk

[svn at flashrom.org]

Author: hailfinger
Date: 2009-12-23 00:54:10 +0100 (Wed, 23 Dec 2009)
New Revision: 814

Modified:
   trunk/spi.c
Log:
Add a few FIXME comments to the generic SPI code.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>


Modified: trunk/spi.c
===================================================================
--- trunk/spi.c	2009-12-22 23:42:04 UTC (rev 813)
+++ trunk/spi.c	2009-12-22 23:54:10 UTC (rev 814)
@@ -807,6 +807,7 @@
 	int result;
 	struct spi_command cmds[] = {
 	{
+	/* FIXME: WRSR requires either EWSR or WREN depending on chip type. */
 		.writecnt	= JEDEC_EWSR_OUTSIZE,
 		.writearr	= (const unsigned char[]){ JEDEC_EWSR },
 		.readcnt	= 0,
@@ -1059,6 +1060,7 @@
 		fprintf(stderr, "ERASE FAILED!\n");
 		return -1;
 	}
+	/* FIXME: This will fail on ICH/VIA SPI. */
 	result = spi_write_enable();
 	if (result)
 		return result;