[flashrom] Support for HY29F002TC-90 rom

[David Borg]

Hello,

Updated the patch to include the comment that FEATURE_ADDR_2AA may be
needed for some chip revisions and
changed FEATURE_SHORT_RESET to FEATURE_EITHER_RESET.

One question about FEATURE_EITHER_RESET, should it be used instead of
FEATURE_SHORT_RESET when the device supports both methods, even though
it defaults to the long reset method?

Patch also includes support for the HY29F002B chip, as it is basically
the same chip, with only the sector ordering being different.

HY29F002T code tested with an HY29F002TC-90 chip, on a GA-6VX7-4X
motherboard, and all features are working. (Logs attached)
I have no means of testing HY29F002B chips.

Signed-off-by: David Borg <borg.db at gmail.com>

Regards,
David


On 18 June 2010 15:24, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> Hi David,
>
> thanks for your patch.
>
> On 18.06.2010 11:20, Michael Karcher wrote:
>> Am Freitag, den 18.06.2010, 10:49 +0200 schrieb David Borg:
>>
>> First: Thank you for submitting this patch to flashrom.
>>
>>> However, I'm not sure what the page_size should be. Datasheet:
>>>
>> No one is. page_size is an underspecified setting that is used in
>> completely different way in different contexts. For byte-wise JEDEC
>> chips, I think the value is not used at all (which should be the
>> long-term goal for every chip, as page_size should get replaced by
>> better defined parameters).
>>
>
> Yes, I will kill page_size soon. It is historical baggage, incorrect in
> some places and we simply try to ignore it wherever possible.
>
>
>>> http://www.datasheetarchive.com/pdf/Datasheet-029/DSA00514421.pdf
>>>
>> Thanks for the link. On reading that data sheet, I found that the
>> datasheet uses 10-bit addresses for the commands (555/2AA). This is
>> expressed as "FEATURE_ADDR_2AA" in flashrom. Could you try whether the
>> patch still works with this feature flag added, and if yes resubmit with
>> it? Your chip seems to ignore the high address bits (which is common
>> behaviour), thats why 5555/2AAA also works.
>>
>
> To be honest, if unlimited addresses work fine, I'm tempted to say we
> should use them. Maybe add some comment to .feature_bits that
> FEATURE_ADDR_2AA would be correct, but it works without.
> Wait.
> I found another datasheet which says we have to use 5555/2AAA for this
> chip: http://www.romservice.ru/datashee/f002.pdf
> Please don't add FEATURE_ADDR_2AA. A small comment that some chip
> revisions may need it may be a good idea, but it may break with older
> chip revs.
>
>
>> Except for FEATURE_ADDR_2AA, the patch is
>>
>
> Sorry to nitpick, but this chip is FEATURE_EITHER_RESET, not
> FEATURE_SHORT_RESET.
>
>
>> Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
>>
>>
>>> Signed-off-by: David Borg (borg.db at gmail.com)
>>>
>> Can you please use angle brackets in the Sign-Off?
>>
>
> Regards,
> Carl-Daniel
>
> --
> http://www.hailfinger.org/
>
>



-- 
David Borg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hy29f002.patch
Type: application/octet-stream
Size: 2542 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100619/95391041/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flashrom-V.log
Type: application/octet-stream
Size: 19052 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100619/95391041/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flashrom-VE.log
Type: application/octet-stream
Size: 19238 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100619/95391041/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flashrom-Vr.log
Type: application/octet-stream
Size: 19046 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100619/95391041/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flashrom-Vw.log
Type: application/octet-stream
Size: 21821 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100619/95391041/attachment-0004.obj>