[flashrom] [PATCH] Avoid transaction errors on ICH SPI

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri May 28 17:53:57 CEST 2010


On 28.05.2010 17:43, Stefan Reinauer wrote:
> On 5/28/10 5:04 PM, Carl-Daniel Hailfinger wrote:
>   
>> On 28.05.2010 16:32, Carl-Daniel Hailfinger wrote:
>>   
>>     
>>> ICH SPI can enforces address restrictions for all accesses which take an
>>> address (well, it could if the chipset implementation was not broken).
>>> Since exploiting the broken implementation is harder than conforming to
>>> the address restrictions wherever possible, conform to the address
>>> restrictions instead.
>>>       
>> Explicitly check for invalid addresses in the ichspi driver and abort
>> early with SPI_INVALID_ADDRESS.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
>
> Acked-by: Stefan Reinauer <stepan at coresystems.de>
>   

Thanks, committed in r1016 with one minor whitespace change.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list