[flashrom] [PATCH] Clean up CONFIG_FOO vs. FOO_SUPPORT mess

Uwe Hermann uwe at hermann-uwe.de
Mon May 31 17:25:53 CEST 2010


On Mon, May 31, 2010 at 03:26:34PM +0200, Carl-Daniel Hailfinger wrote:
> Rediffed against current svn.
> 
> So far, we have up to 4 different names for the same thing (ignoring
> capitalization):
> CONFIG_FT2232SPI (makefile config option)
> FT2232_SPI_SUPPORT (#define)
> ft2232spi (programmer name)
> ft2232_spi.c (programmer file)
> 
> Use CONFIG_* with underscores for makefile config options and #defines
> and kill the useless _SUPPORT idiom.
> Use lowercase names with underscores for programmer names and programmer
> files.
> 
> With this, you can run "grep -i ft2232_spi" and find everything related
> to the ft2232_spi driver. Same applies to all other programmers.
> 
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Looks good and builds for me.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the flashrom mailing list