[flashrom] [PATCH] Use large reads for verify

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Nov 16 18:23:04 CET 2010


On 16.11.2010 17:53, Michael Karcher wrote:
> Am Dienstag, den 16.11.2010, 17:27 +0100 schrieb Carl-Daniel Hailfinger:
>   
>> Thanks to Michael Karcher for reviewing the patch and pointing out a
>> missing abort on read failure.
>>     
>
>   
>> +	ret = flash->read(flash, readbuf, start, len);
>> +	if (ret) {
>> +		msg_gerr("Verification impossible because read failed "
>> +			 "at 0x%x (len 0x%x)\n", start, len);
>> +		return 1;
>>     
>
> make this "return ret" to not lose the error code.
>   

Changed.


> Otherwise, the patch looks good to me.
>
> Acked-By: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
>   

Thanks for the review!
Committed in r1233.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list