[flashrom] [PATCH] Use strlen for const strings

Sean Nelson audiohacked at gmail.com
Fri Oct 15 01:47:05 CEST 2010


  On 9/29/10 5:41 PM, Carl-Daniel Hailfinger wrote:
> Replace sizeof("string")-1 with strlen("string")
>
> We want to avoid calls to strlen at runtime if the string is already
> known at compile time.
> Turns out that gcc and clang will recognize constant strings and compute
> the strlen result already at compile time, so trickery with sizeof only
> reduces readability but does not improve the code.
>
> Signed-off-by: Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Sean Nelson <audiohacked at gmail.com>





More information about the flashrom mailing list