[flashrom] [PATCH] Clean up doit()

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Oct 15 02:01:51 CEST 2010


On 15.10.2010 01:44, Sean Nelson wrote:
>  On 10/14/10 1:57 PM, Carl-Daniel Hailfinger wrote:
>> doit() is the monster function we split off from main() when we created
>> cli_classic() and tried to introduce some abstraction. doit() is a
>> poster child of WTFs on an astronomic scale.
>>
>> Make doit() marginally less bad by factoring out self-contained code.
>>
>> Signed-off-by: Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006 at gmx.net>
> Acked-by: Sean Nelson <audiohacked at gmail.com>

Thanks, committed in r1212.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list