[flashrom] [coreboot] flashrom patch: add support for Abit AB-BM6 board

Uwe Hermann uwe at hermann-uwe.de
Tue Sep 7 19:11:45 CEST 2010


On Tue, Sep 07, 2010 at 09:18:52AM +0200, Michael Karcher wrote:
> Am Dienstag, den 07.09.2010, 09:06 +0200 schrieb Tim ter Laak:
> > This patch adds support for the Abit BM6 board, using DMI string
> > identification, and lists it in print.c .
> > 
> > Signed-off-by: Tim ter Laak <timl at scintilla.utwente.nl>
> Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
> 
> If no one else beats me to it, I will commit tonight.

Looks good to me too, but two small requests:


> Index: board_enable.c
> ===================================================================
> --- board_enable.c      (revision 1153)
> +++ board_enable.c      (working copy)
> @@ -1093,6 +1093,15 @@
> 
>  /*
>   * Suited for:
> + *  - Abit AB-BM6

s/Abit/abit/ for consistency (though we may change the convention later).

And: "AB-BM6" should be just "BM6" as that's the name on the website.
Where does the "AB-" prefix come from? Does it say so on the PCB or
something?

Either way:

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the flashrom mailing list