[flashrom] ASUS P4SC-E Board Enable / IT8707F support

Mattias Mattsson vitplister at gmail.com
Mon Sep 13 21:41:37 CEST 2010


On Mon, Sep 13, 2010 at 20:29, Uwe Hermann <uwe at hermann-uwe.de> wrote:
>> +static int it8707f_write_enable(uint8_t port)
>> +{
>> +     uint8_t tmp;
>> +
>> +     w836xx_ext_enter(port);
>> +
>> +     tmp = sio_read(port, 0x23);
>> +     tmp |= 8;
>
> Please consider (1 << 3) for better readability.

Fixed. Also added some comments.

> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

Thanks, r1161


-mattias




More information about the flashrom mailing list