[flashrom] here's the completely fixed patch.

Stefan Reinauer stefan.reinauer at coreboot.org
Thu Apr 28 00:36:18 CEST 2011


* Brandon Dowdy <brandonrd7 at gmail.com> [110427 23:27]:
> Here is the same patch that is completely looked at and fixed.

This patch does not hook up any of the code it adds. It basically does
nothing. Did you ever try this code before sending it? I'm pretty sure
it doesn't work, whatever the problem is it's trying to solve.

Some other things:

 - why do you call the EC access function UC? 
 - Maybe these functions can be shared with some KBC stuff and/or moved
   to a separate file?
 - Signed-off-by: is missing

Stefan





More information about the flashrom mailing list