[flashrom] [PATCH] Makefile: fix and simplify test program compilations

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sat Aug 13 06:42:02 CEST 2011


On Fri, 12 Aug 2011 21:38:37 +0200
Stefan Tauner <stefan.tauner at student.tuwien.ac.at> wrote:

> side note: we use $(CC) all over the place before we even check if
> it is there. e.g.:
> override ARCH = $(strip $(shell LC_ALL=C $(CC) -E arch.h|grep -v '^\#'))
> 
> this creates unwanted output like:
> make -j1 CC=eiugthes
> /bin/sh: eiugthes: not found
> /bin/sh: eiugthes: not found
> /bin/sh: eiugthes: not found
> /bin/sh: eiugthes: not found
> Checking for a C compiler... not found.
> make: *** [compiler] Error 1

actually it is only this one line that creates the output. the reason it
executes the command 4 times instead of caching it is the use of "="
instead of ":=", see
http://www.gnu.org/s/hello/manual/make/Flavors.html#Flavors

i have added the : to the ARCH definition, but it does not solve the
underlying problem that it is executed before the compiler test:
make -j1  CC=eiugthes
/bin/sh: eiugthes: not found
Checking for a C compiler... not found.
make: *** [compiler] Error 1

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list