[flashrom] [PATCH 3/3] an obvious but dubios refactor opportunity
Tadas Slotkus
devtadas at gmail.com
Mon Aug 15 18:05:23 CEST 2011
> diff --git a/layout.c b/layout.c
> index 8283e36..fe29852 100644
> --- a/layout.c
> +++ b/layout.c
> @@ -240,6 +240,19 @@ static struct rom_entry *get_next_included_romentry(unsigned int start)
> return best_entry;
> }
>
> +static void copy_old_content(struct flashchip *flash, int oldcontents_valid, uint8_t *oldcontents, uint8_t *newcontents, unsigned int start, unsigned int size)
Could you split it to multiple lines?
Nice work! :)
Acked-by: Tadas Slotkus <devtadas at gmail.com>
Thanks,
Tadas
More information about the flashrom
mailing list