[flashrom] [PATCH 1/3] layout: change return type and name of find_next_included_romentry

Tadas Slotkus devtadas at gmail.com
Thu Aug 18 12:32:39 CEST 2011


> hello tadas
> 
> nice to see someone reading my patches!
> but TBH the three reviews look a bit superficial as far as one can
> judge that from the mails alone (which might be wrong and in that case
> please accept my apologies).
> 
> you can't just ack a patch named "an obvious but *dubios* refactor
> opportunity" without any discussion for example :)
> why do you think it is worth it and should be included?
> also, see my mail regarding 1/3.
> 
> i am not much involved in coreboot development, but in flashrom we are
> very picky about almost any change. :)
> we think this helps code quality a lot. OTOH our patch queue is so long
> because we don't have enough time to review. rigorous reviews take a
> lot of time and effort. if you are not entirely sure that a change
> should be committed, just tell what you think without appending your
> acked-by.
> 
> that all said, i appreciate any comment regarding my patches very much.
> thank you!
> 

Hi,

yep you are right, anyways I like the main idea. At least it makes more
clear what is going on.

Thanks,
Tadas





More information about the flashrom mailing list