[flashrom] [PATCH] chipset_enable.c: add a message in the case the chipset enable is untested

Uwe Hermann uwe at hermann-uwe.de
Fri Jul 22 12:48:37 CEST 2011


On Fri, Jul 22, 2011 at 10:05:10AM +0200, Stefan Tauner wrote:
> > > seriously... i thought it is better to call the chipset enable after the
> > > message. and TBH i did not put too much thought into reducing line
> > > count, because my message was already way shorter than the chip message.
> > > till now i was mainly concerned about character/word count in messages
> > > not line count. dos users... well they should get an OS, use redirection
> > > or not get in my way :P
> > >   
> > 
> > You'd be surprised how many of our users use DOS, usually because they
> > don't know Linux.

Just a side-note, this is not really about DOS, I use 80x25 xterms on
Linux all the time. But I have no problem with one or two lines more or
less in the output, either way.

DOS users have a problem with -V output already I assume, whatever they
do to handle that can probably also be applied to the case without -V.

 
> option (for me). i will try to factor in their line limit and inability
> to scroll (is that still correct for freedos?) in future patches though.

No idea if scrolling is possible or not. I think the best option would
be to have a more finegrained control of the loglevel in flashrom, i.e.
--log-level=0,1,2,3 etc. (instead of "no -V", "-V", and "-VV"), so the
user can also choose 0 or 1 to get only the bare minumum output.


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the flashrom mailing list