[flashrom] [commit] r1397 - trunk

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sun Jul 31 17:15:19 CEST 2011


On Thu, 28 Jul 2011 10:13:25 +0200
repository service <svn at flashrom.org> wrote:

> -	int i;
>  	char *idsel = NULL;
> -	int tmp;
> -	int max_decode_fwh_idsel = 0;
> -	int max_decode_fwh_decode = 0;
> +	int i, tmp, max_decode_fwh_idsel = 0, max_decode_fwh_decode = 0;

this kind of mixing declarations with and without initializations is
awful imho. i don't like multiple variables in one declaration except
for simple counters etc, but this is even worse...
</my 2 ct>

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list