[flashrom] [PATCH] Remove erase_chip_stm50flw0x0x

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sun Jun 26 18:35:38 CEST 2011


On Fri, 15 Apr 2011 01:30:33 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Am 09.03.2011 02:52 schrieb Michael Karcher:
> > As the comment indicates, that function is not a chip erase function
> > at all, but a function calling a block eraser in a loop. So it adds
> > no extra value to what we already have in the block_eraser
> > infrastructure.
> >
> > Furthermore, that function assumes a uniform sector size layout, but
> > is referenced from flash chip with non-uniform sector size layout, which
> > is just wrong.
> >    
> 
> Great, even more code killed. Thanks for your patch.
> 
> 
> > Signed-off-by: Michael Karcher<flashrom at mkarcher.dialup.fu-berlin.de>
> >    
> 
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> 
> Please compile test, then commit.

was committed in r1287
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list