[flashrom] [PATCH] don't print dmidecode shell error

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Mon Jun 27 15:29:09 CEST 2011


On Mon, 27 Jun 2011 14:54:49 +0200
Bernd Blaauw <bblaauw at home.nl> wrote:

> Op 27-6-2011 14:44, Stefan Tauner schreef:
> > stepan told me to commit this, but i hesitate. i want to integrate
> > dos/win support first.
> >
> > i would drop the __DJGPP__ flag there because /dev/null is supported by
> > it: http://www.delorie.com/djgpp/doc/eli-m17n99.html#Unix%20devices
> > additionally i would use 2>NUL for win32. for xp there is official
> > documentation. a friend of mine also tried it on win2k so i would say
> > it is fairly safe to use it?
> 
> It would be kind to be able to detect a missing DMIDECOD.EXE (DOS) or 
> DMIDECODE.EXE (LFN platforms, likely thus only Windows/ReactOS) only 
> once, instead of ending up with
> 6 times the line "bad command or filename" (sent to stdout only, unable 
> to redirect to textfile).
does it with the previously attached patch still?

> Searching current directory, flashrom's 
> directory as well as entire path, should do, I guess.
patches are welcome ;)
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list