[flashrom] [PATCH 00/11] ichspi patches 4.0 - logs showing the new output

[Stefan Tauner]

On Sun, 29 May 2011 17:51:46 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> With all due respect, this is too long to be useful. We want verbose
> output to be as short as possible for any given piece of info. ICH
> verbose output was already too much, but 89 additional lines are a real
> problem for cut-n-paste.
> 
> Right now we have the following message levels:
> ERR, INFO, DEBUG, BARF.
> -V gives you everything up to (including) DEBUG.
> -VV gives you really everything and is useless unless you're debugging a
> driver.
> 
> We could introduce an additional message level DEBUG2 (msg_[pcg]dbg2)
> between DEBUG and BARF and require -VVV for BARF. Quite a few ICH debug
> messages could be moved to DEBUG2 and we'd keep the normal verbose
> output readable. That would remove some of the pressure for keeping
> messages terse. However, even with DEBUG2 we want a reasonable set of
> DEBUG messages.
> 
> I'd like to open a discussion about this before we proceed.

i have said ichspi is too verbose multiple times in the past and
everybody told me "nah, we want all possible output that helps
debugging". the descriptor contents are important if we debug hardware
sequencing and/or descriptor mode and the output in my log is only
produced if descriptors are enabled (iirc). regarding the format
itself... that is based on mazzoo's work and i have not changed much. i
can look into it and trim/compress it where i think it does make sense.

but copy&paste should not be considered as a problematic use case imho.
the output should be captured by a logfile option (on my growing todo
list :P) or with redirection. but too verbose output is a usability
problem in itself, because not seeing the forest for the trees etc., so
i basically agree with you.

i could live with using barf for the moment, but imho it does make
sense to differentiate more too (it's just more work and ichspi would
be the only user for now).

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner