[flashrom] [PATCH 2/6] Add a convenient libflashrom interface

Nico Huber nico.huber at secunet.com
Mon Dec 10 15:34:10 CET 2012


This adds a minimal libflashrom interface based on the draft in the
wiki. While the glue code in libflashrom.c is build on top of the
existing code instead on overhauling it, the interface in libflashrom.h
is supposed to be stable. So we can keep the interface and adapt
internals later if favoured, without breaking clients.

A new make target, libinstall, is also added. It installs libflashrom.a
and libflashrom.h in lib/ and include/ dirs respectively.

This commit breaks build of the cli. It will be fixed with a follow-up
commit.

Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 Makefile      |    8 +-
 libflashrom.c |  443 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 libflashrom.h |   55 +++++++
 3 files changed, 505 insertions(+), 1 deletion(-)
 create mode 100644 libflashrom.c
 create mode 100644 libflashrom.h

diff --git a/Makefile b/Makefile
index f3cb07a..5f164f5 100644
--- a/Makefile
+++ b/Makefile
@@ -302,7 +302,7 @@ CHIP_OBJS = jedec.o stm50flw0x0x.o w39.o w29ee011.o \
 ###############################################################################
 # Library code.
 
-LIB_OBJS = layout.o flashrom.o udelay.o programmer.o
+LIB_OBJS = libflashrom.o layout.o flashrom.o udelay.o programmer.o
 
 ###############################################################################
 # Frontend related stuff.
@@ -832,6 +832,12 @@ install: $(PROGRAM)$(EXEC_SUFFIX)
 	$(INSTALL) -m 0755 $(PROGRAM)$(EXEC_SUFFIX) $(DESTDIR)$(PREFIX)/sbin
 	$(INSTALL) -m 0644 $(PROGRAM).8 $(DESTDIR)$(MANDIR)/man8
 
+libinstall: libflashrom.a libflashrom.h
+	mkdir -p $(DESTDIR)$(PREFIX)/lib
+	$(INSTALL) -m 0644 libflashrom.a $(DESTDIR)$(PREFIX)/lib
+	mkdir -p $(DESTDIR)$(PREFIX)/include
+	$(INSTALL) -m 0644 libflashrom.h $(DESTDIR)$(PREFIX)/include
+
 export:
 	@rm -rf $(EXPORTDIR)/flashrom-$(RELEASENAME)
 	@svn export -r BASE . $(EXPORTDIR)/flashrom-$(RELEASENAME)
diff --git a/libflashrom.c b/libflashrom.c
new file mode 100644
index 0000000..507fee9
--- /dev/null
+++ b/libflashrom.c
@@ -0,0 +1,443 @@
+/*
+ * This file is part of the flashrom project.
+ *
+ * Copyright (C) 2012 secunet Security Networks AG
+ * (Written by Nico Huber <nico.huber at secunet.com> for secunet)
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+/**
+ * @mainpage
+ *
+ * Have a look at the Modules section for a function reference.
+ */
+
+#include <stdlib.h>
+#include <string.h>
+#include <stdarg.h>
+
+#include "flash.h"
+#include "programmer.h"
+#include "libflashrom.h"
+
+/**
+ * @defgroup fl-general General
+ * @{
+ */
+
+/** Pointer to log callback function. */
+static fl_log_callback_t *fl_log_callback = NULL;
+
+/**
+ * @brief Initialize libflashrom.
+ *
+ * @param perform_selfcheck If not zero, perform a self check.
+ * @return 0 on success
+ */
+int fl_init(const int perform_selfcheck)
+{
+	if (perform_selfcheck && selfcheck())
+		return 1;
+	myusec_calibrate_delay();
+	return 0;
+}
+
+/**
+ * @brief Shut down libflashrom.
+ * @return 0 on success
+ */
+int fl_shutdown(void)
+{
+	return 0; /* TODO: nothing to do? */
+}
+
+/* TODO: fl_set_loglevel()? do we need it?
+         For now, let the user decide in his callback. */
+
+/**
+ * @brief Set the log callback function.
+ *
+ * Set a callback function which will be invoked whenever libflashrom wants
+ * to output messages. This allows frontends to do whatever they see fit with
+ * such messages, e.g. write them to syslog, or to file, or print them in a
+ * GUI window, etc.
+ *
+ * @param log_callback Pointer to the new log callback function.
+ */
+void fl_set_log_callback(fl_log_callback_t *const log_callback)
+{
+	fl_log_callback = log_callback;
+}
+/** @private */
+int print(const enum msglevel level, const char *const fmt, ...)
+{
+	if (fl_log_callback) {
+		int ret;
+		va_list args;
+		va_start(args, fmt);
+		ret = fl_log_callback(level, fmt, args);
+		va_end(args);
+		return ret;
+	}
+	return 0;
+}
+
+/** @} */ /* end fl-general */
+
+
+
+/**
+ * @defgroup fl-query Querying
+ * @{
+ */
+
+/* TBD */
+
+/** @} */ /* end fl-query */
+
+
+
+/**
+ * @defgroup fl-prog Programmers
+ * @{
+ */
+
+/**
+ * @brief Initialize the specified programmer.
+ *
+ * @param prog_name Name of the programmer to initialize.
+ * @param prog_param Pointer to programmer specific parameters.
+ * @return 0 on success
+ */
+int fl_programmer_init(const char *const prog_name, const char *const prog_param)
+{
+	unsigned prog;
+
+	for (prog = 0; prog < PROGRAMMER_INVALID; prog++) {
+		if (strcmp(prog_name, programmer_table[prog].name) == 0)
+			break;
+	}
+	if (prog >= PROGRAMMER_INVALID) {
+		msg_ginfo("Error: Unknown programmer \"%s\". Valid choices are:\n", prog_name);
+		list_programmers_linebreak(0, 80, 0);
+		return 1;
+	}
+	return programmer_init(prog, prog_param);
+}
+
+/**
+ * @brief Shut down the initialized programmer.
+ *
+ * @return 0 on success
+ */
+int fl_programmer_shutdown(void)
+{
+	return programmer_shutdown();
+}
+
+/* TODO: fl_programmer_capabilities()? */
+
+/** @} */ /* end fl-prog */
+
+
+
+/**
+ * @defgroup fl-flash Flash chips
+ * @{
+ */
+
+/**
+ * @brief Probe for a flash chip.
+ *
+ * Probes for a flash chip and returns a flash context, that can be used
+ * later with flash chip and @ref fl-ops "image operations", if exactly one
+ * matching chip is found.
+ *
+ * @param[out] flashctx Points to a pointer of type fl_flashctx_t that will
+ *                      be set if exactly one chip is found. *flashctx has
+ *                      to be freed by the caller with @ref fl_flash_release.
+ * @param[in] chip_name Name of a chip to probe for, or NULL to probe for
+ *                      all known chips.
+ * @return 0 on success,
+ *         3 if multiple chips were found,
+ *         2 if no chip was found,
+ *         or 1 on any other error.
+ */
+int fl_flash_probe(fl_flashctx_t **const flashctx, const char *const chip_name)
+{
+	int i, ret = 2;
+	fl_flashctx_t second_flashctx = { 0, };
+
+	chip_to_probe = chip_name; /* chip_to_probe is global in flashrom.c */
+
+	*flashctx = malloc(sizeof(**flashctx));
+	if (!*flashctx)
+		return 1;
+	memset(*flashctx, 0, sizeof(**flashctx));
+
+	for (i = 0; i < registered_programmer_count; ++i) {
+		int flash_idx = -1;
+		if (!ret || (flash_idx = probe_flash(&registered_programmers[i], 0, *flashctx, 0)) != -1) {
+			ret = 0;
+			/* We found one chip, now check that there is no second match. */
+			if (probe_flash(&registered_programmers[i], flash_idx + 1, &second_flashctx, 0) != -1) {
+				ret = 3;
+				break;
+			}
+		}
+	}
+	if (ret) {
+		free(*flashctx);
+		*flashctx = NULL;
+	}
+	return ret;
+}
+
+/**
+ * @brief Returns the size of the specified flash chip in bytes.
+ *
+ * @param flashctx The queried flash context.
+ * @return Size of flash chip in bytes.
+ */
+size_t fl_flash_getsize(const fl_flashctx_t *const flashctx)
+{
+	return flashctx->chip->total_size << 10;
+}
+
+/** @private */
+int erase_and_write_flash(struct flashctx *flash, uint8_t *oldcontents, uint8_t *newcontents);
+/** @private */
+void emergency_help_message(void);
+/**
+ * @brief Erase the specified ROM chip.
+ *
+ * @param flashctx The context of the flash chip to erase.
+ * @return 0 on success.
+ */
+int fl_flash_erase(fl_flashctx_t *const flashctx)
+{
+	const size_t flash_size = flashctx->chip->total_size * 1024;
+
+	int ret = 0;
+
+	uint8_t *const newcontents = malloc(flash_size);
+	if (!newcontents) {
+		msg_gerr("Out of memory!\n");
+		return 1;
+	}
+	uint8_t *const oldcontents = malloc(flash_size);
+	if (!oldcontents) {
+		msg_gerr("Out of memory!\n");
+		free(newcontents);
+		return 1;
+	}
+
+	if (flashctx->chip->unlock)
+		flashctx->chip->unlock(flashctx);
+
+	/* Assume worst case for old contents: All bits are 0. */
+	memset(oldcontents, 0x00, flash_size);
+	/* Assume best case for new contents: All bits should be 1. */
+	memset(newcontents, 0xff, flash_size);
+	/* Side effect of the assumptions above: Default write action is erase
+	 * because newcontents looks like a completely erased chip, and
+	 * oldcontents being completely 0x00 means we have to erase everything
+	 * before we can write.
+	 */
+
+	if (erase_and_write_flash(flashctx, oldcontents, newcontents)) {
+		/* FIXME: Do we really want the scary warning if erase failed?
+		 * After all, after erase the chip is either blank or partially
+		 * blank or it has the old contents. A blank chip won't boot,
+		 * so if the user wanted erase and reboots afterwards, the user
+		 * knows very well that booting won't work.
+		 */
+		emergency_help_message();
+		ret = 1;
+	}
+
+	free(oldcontents);
+	free(newcontents);
+	return ret;
+}
+
+/**
+ * @brief Free a flash context.
+ *
+ * @param flashctx Flash context to free.
+ */
+void fl_flash_release(fl_flashctx_t *const flashctx)
+{
+	free(flashctx);
+}
+
+/** @} */ /* end fl-flash */
+
+
+
+/**
+ * @defgroup fl-ops Operations
+ * @{
+ */
+
+/**
+ * @brief Read the current image from the specified ROM chip.
+ *
+ * @param flashctx The context of the flash chip.
+ * @param buffer Target buffer to write image to.
+ * @param buffer_len Size of target buffer in bytes.
+ * @return 0 on success,
+ *         2 if buffer_len is to short for the flash chip's contents,
+ *         or 1 on any other failure.
+ */
+int fl_image_read(fl_flashctx_t *const flashctx, void *const buffer, const size_t buffer_len)
+{
+	const size_t flash_size = flashctx->chip->total_size * 1024;
+
+	int ret = 0;
+
+	if (flashctx->chip->unlock)
+		flashctx->chip->unlock(flashctx);
+
+	msg_cinfo("Reading flash... ");
+	if (flash_size > buffer_len) {
+		msg_cerr("Buffer to short for this flash chip (%u < %u).\n",
+			 (unsigned int)buffer_len, (unsigned int)flash_size);
+		ret = 2;
+		goto _out;
+	}
+	if (!flashctx->chip->read) {
+		msg_cerr("No read function available for this flash chip.\n");
+		ret = 1;
+		goto _out;
+	}
+	if (flashctx->chip->read(flashctx, buffer, 0, flash_size)) {
+		msg_cerr("Read operation failed!\n");
+		ret = 1;
+		goto _out;
+	}
+_out:
+	msg_cinfo("%s.\n", ret ? "FAILED" : "done");
+	return ret;
+}
+
+/** @private */
+void nonfatal_help_message(void);
+/**
+ * @brief Write the specified image to the ROM chip.
+ *
+ * @param flashctx The context of the flash chip.
+ * @param buffer Source buffer to read image from.
+ * @param buffer_len Size of source buffer in bytes.
+ * @return 0 on success,
+ *         4 if buffer_len doesn't match the size of the flash chip,
+ *         3 if write was tried, but nothing has changed,
+ *         2 if write was tried, but flash contents changed,
+ *         or 1 on any other failure.
+ */
+int fl_image_write(fl_flashctx_t *const flashctx, void *const buffer, const size_t buffer_len)
+{
+	const size_t flash_size = flashctx->chip->total_size * 1024;
+
+	int ret = 0;
+
+	if (buffer_len != flash_size) {
+		msg_cerr("Buffer size doesn't match size of flash chip (%u != %u)\n.",
+			 (unsigned int)buffer_len, (unsigned int)flash_size);
+		return 4;
+	}
+
+	uint8_t *const newcontents = buffer;
+	uint8_t *const oldcontents = malloc(flash_size);
+	if (!oldcontents) {
+		msg_gerr("Out of memory!\n");
+		return 1;
+	}
+	if (fl_image_read(flashctx, oldcontents, flash_size)) {
+		ret = 1;
+		goto _free_out;
+	}
+
+	handle_romentries(flashctx, oldcontents, newcontents);
+
+	if (erase_and_write_flash(flashctx, oldcontents, newcontents)) {
+		msg_cerr("Uh oh. Erase/write failed. Checking if anything changed.\n");
+		if (!flashctx->chip->read(flashctx, newcontents, 0, flash_size)) {
+			if (!memcmp(oldcontents, newcontents, flash_size)) {
+				msg_cinfo("Good. It seems nothing was changed.\n");
+				nonfatal_help_message();
+				ret = 3;
+				goto _free_out;
+			}
+		}
+		emergency_help_message();
+		ret = 2;
+		goto _free_out;
+	}
+
+_free_out:
+	free(oldcontents);
+	return ret;
+}
+
+/** @private */
+int compare_range(uint8_t *wantbuf, uint8_t *havebuf, unsigned int start, unsigned int len);
+/**
+ * @brief Verify the ROM chip's contents with the specified image.
+ *
+ * @param flashctx The context of the flash chip.
+ * @param buffer Source buffer to verify with.
+ * @param buffer_len Size of source buffer in bytes.
+ * @return 0 on success,
+ *         2 if buffer_len doesn't match the size of the flash chip,
+ *         or 1 on any other failure.
+ */
+int fl_image_verify(fl_flashctx_t *const flashctx, void *const buffer, const size_t buffer_len)
+{
+	const size_t flash_size = flashctx->chip->total_size * 1024;
+
+	int ret = 0;
+
+	if (buffer_len != flash_size) {
+		msg_cerr("Buffer size doesn't match size of flash chip (%u != %u)\n.",
+			 (unsigned int)buffer_len, (unsigned int)flash_size);
+		return 2;
+	}
+
+	uint8_t *const newcontents = buffer;
+	uint8_t *const oldcontents = malloc(flash_size);
+	if (!oldcontents) {
+		msg_gerr("Out of memory!\n");
+		return 1;
+	}
+	if (fl_image_read(flashctx, oldcontents, flash_size)) {
+		ret = 1;
+		goto _free_out;
+	}
+
+	handle_romentries(flashctx, oldcontents, newcontents);
+
+	msg_cinfo("Verifying flash... ");
+
+	ret = compare_range(newcontents, oldcontents, 0, flash_size);
+	if (!ret)
+		msg_cinfo("VERIFIED.\n");
+
+_free_out:
+	free(oldcontents);
+	return ret;
+}
+
+/** @} */ /* end fl-ops */
diff --git a/libflashrom.h b/libflashrom.h
new file mode 100644
index 0000000..2077407
--- /dev/null
+++ b/libflashrom.h
@@ -0,0 +1,55 @@
+/*
+ * This file is part of the flashrom project.
+ *
+ * Copyright (C) 2012 secunet Security Networks AG
+ * (Written by Nico Huber <nico.huber at secunet.com> for secunet)
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+#ifndef __LIBFLASHROM_H__
+#define __LIBFLASHROM_H__ 1
+
+#include <stdarg.h>
+
+int fl_init(int perform_selfcheck);
+int fl_shutdown(void);
+/** @ingroup fl-general */
+typedef enum { /* This has to match enum msglevel. */
+	FL_MSG_ERROR	= 0,
+	FL_MSG_INFO	= 1,
+	FL_MSG_DEBUG	= 2,
+	FL_MSG_DEBUG2	= 3,
+	FL_MSG_SPEW	= 4,
+} fl_log_level_t;
+/** @ingroup fl-general */
+typedef int(fl_log_callback_t)(fl_log_level_t, const char *format, va_list);
+void fl_set_log_callback(fl_log_callback_t *);
+
+int fl_programmer_init(const char *prog_name, const char *prog_params);
+int fl_programmer_shutdown(void);
+
+struct flashctx;
+typedef struct flashctx fl_flashctx_t;
+int fl_flash_probe(fl_flashctx_t **, const char *chip_name);
+size_t fl_flash_getsize(const fl_flashctx_t *);
+int fl_flash_erase(fl_flashctx_t *);
+void fl_flash_release(fl_flashctx_t *);
+
+int fl_image_read(fl_flashctx_t *, void *buffer, size_t buffer_len);
+int fl_image_write(fl_flashctx_t *, void *buffer, size_t buffer_len);
+int fl_image_verify(fl_flashctx_t *, void *buffer, size_t buffer_len);
+
+#endif				/* !__LIBFLASHROM_H__ */
-- 
1.7.9.5





More information about the flashrom mailing list