[flashrom] [PATCH] Whitelist known working Thinkpads.
Stefan Tauner
stefan.tauner at student.tuwien.ac.at
Tue Sep 25 23:13:48 CEST 2012
On Tue, 25 Sep 2012 08:51:54 +0200
Paul Menzel <paulepanter at users.sourceforge.net> wrote:
> Dear Stefan,
>
>
> please add T60 and X60 to the commit summary too.
>
> Whitelist known working Thinkpads T60 and X60.
>
>
> Am Montag, den 24.09.2012, 23:38 +0200 schrieb Stefan Tauner:
> > This should get rid of the need to specify the laptop force parameter
> > on T60 and X60 that are using one of the Intel 94x northbridges and
> > are known to have no interfering EC.
>
> »Therefore for example the T60’s image can be read with the following
> command.
>
> $ sudo flashrom -V -r t60.image
>
> > Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> > ---
> > board_enable.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/board_enable.c b/board_enable.c
> > index 28a8fcd..e512064 100644
> > --- a/board_enable.c
> > +++ b/board_enable.c
> > @@ -2243,6 +2243,17 @@ static int p2_not_a_laptop(void)
> > return 0;
> > }
> >
> > +/*
> > + * Suited for all laptops, which are known to work.
> > + */
> > +static int p2_whitelist_laptop(void)
> > +{
> > + is_laptop = 1;
> > + laptop_ok = 1;
> > + msg_pdbg("Whitelisted laptop detected.\n");
> > + return 0;
> > +}
> > +
> > #endif
> >
> > /*
> > @@ -2396,6 +2407,8 @@ const struct board_match board_matches[] = {
> > {0x8086, 0x7190, 0, 0, 0x8086, 0x7110, 0, 0, "^SE440BX-2$", NULL, NULL, P3, "Intel", "SE440BX-2", 0, NT, intel_piix4_gpo27_lower},
> > {0x1022, 0x7468, 0, 0, 0x1022, 0x7460, 0, 0, NULL, "iwill", "dk8_htx", P3, "IWILL", "DK8-HTX", 0, OK, w83627hf_gpio24_raise_2e},
> > {0x8086, 0x27A0, 0x8086, 0x27a0, 0x8086, 0x27b8, 0x8086, 0x27b8, NULL, "kontron", "986lcd-m", P3, "Kontron", "986LCD-M", 0, OK, board_kontron_986lcd_m},
> > + {0x8086, 0x27a0, 0x17aa, 0x2017, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "Lenovo", "T60", 0, OK, p2_whitelist_laptop},
> > + {0x8086, 0x27a0, 0x17aa, 0x2017, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad X60", NULL, NULL, P2, "Lenovo", "X60", 0, OK, p2_whitelist_laptop},
> > {0x8086, 0x2411, 0x8086, 0x2411, 0x8086, 0x7125, 0x0e11, 0xb165, NULL, NULL, NULL, P3, "Mitac", "6513WU", 0, OK, board_mitac_6513wu},
> > {0x8086, 0x8186, 0x8086, 0x8186, 0x8086, 0x8800, 0x0000, 0x0000, "^MSC Vertriebs GmbH$", NULL, NULL, P2, "MSC", "Q7-TCTC", 0, OK, p2_not_a_laptop},
> > {0x10DE, 0x005E, 0x1462, 0x7125, 0x10DE, 0x0052, 0x1462, 0x7125, NULL, NULL, NULL, P3, "MSI", "K8N Neo4-F", 0, OK, nvidia_mcp_gpio2_raise}, /* TODO: Should probably be K8N Neo4 Platinum, see http://www.coreboot.org/pipermail/flashrom/2010-August/004362.html. */
>
> Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>
Thanks Paul. I left out the CLI example, but i explained better what
this change actually means. I hope that is even better (in the unlikely
case a user actually reads it :).
Committed in r1606.
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom
mailing list