[flashrom] [PATCH] Unify PCI init and let pcidev clean itself up.
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Wed Jan 2 18:58:16 CET 2013
Am 02.01.2013 15:43 schrieb Stefan Tauner:
> Previously the internal programmer used its own code to initialize pcilib.
> This patch extracts the common code from the internal programmer and
> pcidev_init() into pcidev_init_common().
> This fixes the non-existent PCI cleanup of the internal programmer and adds
> an additional safety by checking for an already existing PCI context.
>
> We got a nice shutdown function registration infrastructure, but did not use it
> very wisely. Instead we added shutdown functions to a myriad of programmers
> unnecessarily. In this patch we get rid of those that do only call pci_cleanup(pacc)
> by adding a shutdown function the pcidev.c itself that gets registered by
> pcidev_init().
>
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
Great work!
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the flashrom
mailing list