[flashrom] [PATCH] CID1130009: Resource leak

Stefan Reinauer stefan.reinauer at coreboot.org
Tue Nov 19 20:35:57 CET 2013


CID1130009: Resource leak

The system resource will not be reclaimed and reused, reducing the future
availability of the resource.
In sp_opensocket: Leak of memory or pointers to system resources

Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Index: serprog.c
===================================================================
--- serprog.c	(revision 1763)
+++ serprog.c	(working copy)
@@ -100,6 +100,7 @@
 	if (NULL == hostPtr) {
 		hostPtr = gethostbyaddr(ip, strlen(ip), AF_INET);
 		if (NULL == hostPtr) {
+			close(sock);
 			msg_perr("Error: cannot resolve %s\n", ip);
 			return -1;
 		}




More information about the flashrom mailing list