[flashrom] New motherboard

[Stefan Tauner]

On Mon, 14 Jul 2014 05:51:50 +0400
Dima Veselov <kab00m at lich.phys.spbu.ru> wrote:

> On Mon, Jul 14, 2014 at 01:06:18AM +0200, Stefan Tauner wrote:
>
> > Hello Dima,
> > 
> > thanks for your patch! You wrote that you have successfully flashed
> > your board after applying the changes in your patch, but there is no
> > log file showing that. 
> 
> I used Vintage to flash MSI chip replacing it on the fly. All the
> utilities failed to work, I had to boot machine many times, each time
> replacing chips. So, when it finally happened - I was too happy to 
> record log-file :) Just beleive me :)

No problem, I just wanted to make sure I have understood you correctly.

> 
> > Also, both entries (in print.c and
> > board_enable.c) mark the board with "NT" (i.e. not tested). I wonder
> > why you did not mark them with "OK"?
> 
> I am not a code guru, so I just copy/pasted P5LD2 strings as the most
> close one, honestly I was sure it IS P5LD2, but noticed 27b8/27b0
> difference later. Sending patch I wasn't sure my only word will
> state this enough to approve motherboard for entire project :)
> 
> > We would also like to acknowledge your authorship by adding your
> > signed-off-by line (and even require that for more complex patches).
> > See http://flashrom.org/Developer_Guidelines#Sign-off_Procedure for
> > details. In simple cases like this that do not reach the threshold of
> > originality I could commit it without it, but I'd appreciate it if you
> > would resend the patch possibly with the status fields changed and a
> > proper signed-off-by line if you wish.
> 
> See attachment. Don't have git, but patch works :)
> 

Thank you very much for all the clarifications and the updated patch.
I have slightly refined it and committed it in r1828.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner