[flashrom] [PATCH] Add support for S25FL128P and S25FL128P......0 chips.

[Antonio Ospite]

On Sun, 29 Jun 2014 13:29:00 +0200
Antonio Ospite <ao2 at ao2.it> wrote:

> On Fri, 13 Jun 2014 10:41:39 +0200
> Stefan Tauner <stefan.tauner at alumni.tuwien.ac.at> wrote:
> 
> > Thanks for the test, there are two issues here. One is that I swapped
> > the erase block sizes of the P models. This is clearly shown in your
> > logs.
> > The ...0 model should have 64 kB erase blocks, but does not:
> > > Trying erase function 0... 0x000000-0x03ffff:EFAILED at 0x00010000! Expected=0xff, Found=0xe5
> > 0x03ffff is 262143 in decimal... I have fixed that locally, but this is
> > not the main problem here.
> > 
> 
> Hi Stefan, can please you send the fixed up patch for that?
> I can test it with a S25FL129P1.
> 

OK, I fixed up the sizes myself, here are the write tests attached.

Before each run I create data.bin with:
dd if=/dev/urandom count=$((16 * 1024 * 1024)) iflag=count_bytes of=data.bin

Note that I have a S25FL129P......0, not S25FL128P......0, for me
spi_block_erase_20 does not work at 64kB, but spi_block_erase_d8 does.

This is because on S25FL129P......0 spi_block_erase_20 is used for the 4kB
access.

If you send an updated version of the patch I can do more tests.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: S25FL129P......0_test.log
Type: application/octet-stream
Size: 8461 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20140630/79e647ee/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: S25FL129P......1_test.log
Type: application/octet-stream
Size: 2851 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20140630/79e647ee/attachment-0001.obj>