[flashrom] Patch for "LE25FW406A"

[Stefan Tauner]

On Wed, 14 May 2014 17:02:48 +0200
The Raven <originalraven at hotmail.com> wrote:

> Here is a Patch (r1791) for adding "LE25FW406A".
> 
> Tested:
> Probe -> Probing for Sanyo LE25FW406A, 512 kB: probe_spi_res2: id1 0x62,
> id2 0x1a
> Read -> ok
> Erase -> ok
> Write -> 512kb random data ok
> Verify -> ok
> 
> It also adds "/* Sanyo */" description to the Sanyo-Chips. This is only
> a cosmetic thing.

Hi and thanks for your patch!

You will have to sign off the patch with your real name too.
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Since I doubt that this patch reaches the threshold of originality
needed to become "your" work (at least in somewhat sane jurisdictions),
I can also sign it off myself if you prefer that, but IMHO you should
stand by your work. :)

Since we do not have a datasheet for this chip, it would be good if you
could test all erase functions dedicatedly by commenting out all but
one eraser block in flashchips.c (Since flashrom tries the top most
first, you can leave out testing it), e.g.:
//				.eraseblocks = { {4 * 1024, 128} },
//				.block_erase = spi_block_erase_d7,
//			},	{


When you are at it anyway, please capture one verbose log. I'd like to
see if we can spot anything interesting. Where did you find the chip
BTW?

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner