[flashrom] [PATCH 4/5] dediprog: Support new communication protocol.

David Woodhouse dwmw2 at infradead.org
Fri Jul 3 10:47:22 CEST 2015


On Mon, 2015-06-22 at 03:37 +0200, Stefan Tauner wrote:
> +/* Returns true if firmware (and thus hardware) supports the "new" protocol */
> +static bool is_new_prot(void)
>  {
> -       size_t i;
> +       /* if (SF100) */
> +       return dediprog_firmwareversion >= FIRMWARE_VERSION(5, 5, 0);
> +       /* else if (SF600)
> +       return dediprog_firmwareversion >= FIRMWARE_VERSION(6, 9, 0); 
> */

... and in dediprog_check_devicestring() we still have:

	msg_pdbg("Found a %s\n", buf);
	if (memcmp(buf, "SF100", 0x5) != 0) {
		msg_perr("Device not a SF100!\n");
		return 1;
	}

Is this patch set actually intended to support SF600? I had assumed so,
so I've rounded up some potential testers for that, and was just trying
to put together something for them to test...

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation





More information about the flashrom mailing list